No subject


Tue Jan 4 04:09:52 UTC 2011


actually be able to coexist, but only if mine loads first.

>> +def list(ui, repo):
>> + =C2=A0 =C2=A0for root, _ignored, files in os.walk(repo.root):
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0for file in files:
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if len(root + file)>=3D 259:
>
> MAXPATH - 1?
>
> "contrib/check-code.py hgext/win32lfn.py" will complain here.

Hmm, not for me. I've been running that actually. The only complaint
it has is about one line that's too long, that I deliberately left in
because it's a URL. I can split that line if desired. I'll replace the
magic number though.

>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0c =3D ui.prompt=
choice(_("Delete %s? [N/y]") % path,
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(_("&No"), _("&Yes")=
), 0)
>
> promptchoice is usually used with prompts such as "lowercase...(yn)".

OK, I should have looked harder for an example.

>
> Mercurial don't use commands with multiple keywords. It is one keyword an=
d a
> number of options.
>
> I suggest you use two completely different commands. Especially because t=
he
> commands do something completely different.

OK

> Finally:
>
> Many fine extensions have their own life and isn't distributed with
> Mercurial. That has the advantage that they can support multiple Mercuria=
l
> versions (if they can) and they can use their own release and bugfix
> schedule.

Yes, I hear you. I do consider it an unfortunate weakness of Mercurial
that it can have repositories that it's unable to checkout on Windows.
And it's a regression if someone is moving from SVN, because
TortoiseSVN at least is able to check out these same projects.

> Extensions might be accepted in Mercurial if they have proven that they a=
re
> stable and widely used and actively maintained.
>
> I suggest you publish this extension somewhere (for example on bitbucket)
> and add it to http://mercurial.selenic.com/wiki/UsingExtensions . Time wi=
ll
> tell if it would be better to distribute it with Mercurial.

Alright

> I don't know how much you have looked at the fixut8 and win32mbcs
> extensions. They solve similar problems in a similar way but do it very
> differently. Who should learn from who? Are they compatible? Could they
> share some infrastructure?

As I said, the list of patched functions is actually very similar
between my patch and win32mbcs. It is perhaps a little less startling
in win32mbcs because it's less obvious exactly how many functions are
being patched!

I don't have a shiftjis system to test on, but I would guess that my
extension would coexist well with mbcs if mine loads first. If mine
loads second, I can tell that some of the patches mbcs needs would be
lost.

--Aaron


More information about the Mercurial-devel mailing list