[PATCH 1 of 2 v2] subrepo: make update -C for svn and git subrepos clean the working directory
Mads Kiilerich
mads at kiilerich.com
Wed Jan 26 17:38:17 CST 2011
Erik Zielke wrote, On 01/26/2011 01:20 PM:
> # HG changeset patch
> # User Erik Zielke<ez at aragost.com>
> # Date 1296043837 -3600
> # Node ID 4c003dc9ab3cd8f379f9f761931bddcf03bce21e
> # Parent 82d01ca87863e74dbf3ff1adc8c065620703a54a
> subrepo: make update -C for svn and git subrepos clean the working directory
...
> --- /dev/null
> +++ b/tests/test-subrepo-update-clean.t
Is it really necessary to add a whole new test? Couldn't it be added to
some existing tests and use the subrepos already built there? Especially
because ...
> @@ -0,0 +1,181 @@
> +Creating git repository
> + $ git init gitrepo -q
> + $ cd gitrepo
> + $ echo c> f0
> + $ git add f0
> + $ git commit -m0 -q
> + $ cd ..
> +
> +Creating svn repository
> + $ svnadmin create svnrepo
> + $ svn co -q file://$TESTTMP/svnrepo svnrepoco
> + $ cd svnrepoco
> + $ echo c> f1
> + $ svn add f1
> + A f1
> + $ svn commit -m0 -q
> + $ cd ..
hghave should be used to check for git and svn, and the git and svn
parts should thus be in different test files.
/Mads
More information about the Mercurial-devel
mailing list