[PATCH STABLE V2] windows: implement nlinks() using Python's ctypes (issue1922)

Steve Borho steve at borho.org
Thu Jan 27 15:59:32 CST 2011


On Thu, Jan 27, 2011 at 3:41 PM, Matt Mackall <mpm at selenic.com> wrote:
> On Wed, 2011-01-26 at 23:50 +0100, Adrian Buehlmann wrote:
>> On 2011-01-26 22:31, Matt Mackall wrote:
>> > On Wed, 2011-01-26 at 17:56 +0100, Adrian Buehlmann wrote:
>> >> Can we require Python >=2.5 (at least for Windows) for 1.8?
>> >
>> > I'd rather keep the requirements in sync with the rest of the world.
>>
>> Would it be ok to require that those users who want to stick with Python
>> 2.4 on Windows (and who don't use one of the public well known binary
>> installers of Mercurial which include Python) have to install ctypes
>> instead of pywin32 for Mercurial 1.8?
>
> Well pywin32 has only every been a (really strong) recommendation, so if
> we swap that out for ctypes, sure.
>
> Steve, how attached is Tortoise to pywin32?

We use it for specialized process launch parameters and for the
overlay server (though much of this could be migrated to PyQt).  I
believe the keyring library is dependent on it to access the Windows
credentials API.  So I don't think we'll stop shipping with it anytime
soon.

All of the Windows installers I build come with Python 2.6, so ctypes
is not a problem.

-- 
Steve Borho


More information about the Mercurial-devel mailing list