autopager extension broken in Mercurial 1.9

[Idan Kamara]

On Thu, Jul 7, 2011 at 1:01 AM, Yann E. MORIN
<yann.morin.1998 at anciens.enib.fr> wrote:
>
> Brodie, All,
>
> I just upgraded to Mercurial 1.9, and noticed that the autopager
> extension [0][1] is now broken.
>
> I managed to bisect Mercurial to:
>
> # hg up -r 1.8 && hg bisect --good
> # hg up -r 1.9 && hg bisect --bad
> [-- build and test, until: --]
> # hg bisect --bad
> The first bad revision is:
> changeset:   14614:afccc64eea73
> user:        Idan Kamara <idankk86 at gmail.com>
> date:        Wed Jun 08 01:39:20 2011 +0300
> summary:     ui: use I/O descriptors internally
>
> I'm clueless here... :-/
>
> I tried comparing autopager.py to pager.py, but I could not see any
> meaningful difference (to me!).
>
> Any help in solving this issue would be most welcome. :-)

It looks like this extension is wrapping sys.stdout/err. I think it
needs to mess with the ui descriptors instead,
since hg uses those for any kind of output now.

>
> Note: I'm using autopager in place of pager, because pager lacks a single
> feature from autopager: handling of the prompt size. It is suggested to use
> less' -F, but my prompt is 2-line high, and in case the output is strictly
> one terminal high minus one line, the top-most line is eaten. And there's
> no way telling 'less' about that.
>
> [0] http://mercurial.selenic.com/wiki/AutopagerExtension
> [1] https://bitbucket.org/brodie/autopager/wiki/Home
>
> Regards,
> Yann E. MORIN
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel