RFC: Changing "committing subrepo foo" messages.

[Matt Mackall]

On Fri, 2011-07-08 at 17:12 -0400, Steve Losh wrote:
> Something that often scares me when using Mercurial is seeing the "committing
> subreposity foo" messages.
> 
> A few seconds later I relax as I realize that Mercurial is not actually committing
> the subrepo (since I have ui.commitsubrepos set to False) but is actually just
> recording the new state of the subrepo in the .hgsubstate of the container repo.
> 
> I think the "committing subrepo foo" message is confusing, especially since there's
> a "commitsubrepos" config option that doesn't prevent it.
> 
> What do people think about the following:
> 
> * If a subrepo is actually being committed, show "committing subrepo foo".
> * Then show a message like "recording new state for subrepo foo".
> 
> This would mean that in my case, when I'm just recording a new state of a subrepo I'd
> just the the "recording" message, and those people that actually use recursive commit
> would see multiple, explicit messages:
> 
>     committing subrepository foo
>     recording new state for subrepository foo
>     committing subrepository bar
>     recording new state for subrepository bar
>     recording new state for subrepository baz

That's way too noisy.

We should only report when we actually do a recursive commit.
Unfortunately, it's a bit tricky to do this cleanly/efficiently at the
moment due to the way subrepo.dirty() works.

-- 
Mathematics is the supreme nostalgia of our time.