[issue2891] hgcia broken by fix for issue2406

Matt Mackall bugs at mercurial.selenic.com
Fri Jul 8 17:15:43 CDT 2011


New submission from Matt Mackall <mpm at selenic.com>:

As reported in issue2406 msg16696:

@@ -66,6 +68,8 @@
         self.cia = cia
         self.ctx = ctx
         self.url = self.cia.url
+        if self.url:
+            self.url += self.cia.root

These two lines are wrong and should be reverted (they insert the full
filesystem path inside the URL).

---

This is a regression and is therefore urgent. I don't even know what a 'cia'
is so the above report doesn't actually help me at all. Hopefully someone
will explain what the original patch was supposed to do, what it did wrong,
and why the above patch does or doesn't break its intended behavior in
enough detail that someone can take some action on it.

If you're on the nosy list, this means you.

----------
messages: 16760
nosy: brendan, ced, mpm, pitrou
priority: urgent
status: unread
title: hgcia broken by fix for issue2406

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue2891>
____________________________________________________


More information about the Mercurial-devel mailing list