RFC: Changing "committing subrepo foo" messages.

[Steve Losh]

On 07/08, Augie Fackler wrote:
> On Fri, Jul 8, 2011 at 4:55 PM, Matt Mackall <mpm at selenic.com> wrote:
> > On Fri, 2011-07-08 at 17:12 -0400, Steve Losh wrote:
> >> This would mean that in my case, when I'm just recording a new state of a subrepo I'd
> >> just the the "recording" message, and those people that actually use recursive commit
> >> would see multiple, explicit messages:
> >>
> >>     committing subrepository foo
> >>     recording new state for subrepository foo
> >>     committing subrepository bar
> >>     recording new state for subrepository bar
> >>     recording new state for subrepository baz
> >
> > That's way too noisy.
> >
> > We should only report when we actually do a recursive commit.
> > Unfortunately, it's a bit tricky to do this cleanly/efficiently at the
> > moment due to the way subrepo.dirty() works.
> 
> How about only reporting that we're recording the new subrepo state if
> we don't cause a recursive commit? I only suggest this because status
> doesn't show the subrepo as having a modified state by default, and
> otherwise the state change could be more than a little surprising.

I thought about that, but it feels weird to have the "recording state" message some
of the time when it's actually happening every time.

-- 
Steve Losh