[PATCH] util: eliminate wildcard imports

Matt Mackall mpm at selenic.com
Sat Jul 23 13:16:48 CDT 2011


On Sat, 2011-07-23 at 20:08 +0200, Adrian Buehlmann wrote:
> On 2011-07-23 19:58, Matt Mackall wrote:
> > On Sat, 2011-07-23 at 15:34 +0200, Adrian Buehlmann wrote:
> >> # HG changeset patch
> >> # User Adrian Buehlmann <adrian at cadifra.com>
> >> # Date 1311416992 -7200
> >> # Node ID f512f94029d77b9dd67455ae7c5668539f695edd
> >> # Parent  ebdfdba0faafc5728b2dd4084fed50d06a6fad60
> >> util: eliminate wildcard imports
> > 
> > What's the motivation for this?
> 
> Mads :-)

My observations are:

- wildcard imports are ugly
- ..but doing it manually is significantly uglier
- wildcard imports defeats demand-loading
- ..but so does doing it manually
- wildcard imports are bad due to namespace pollution
- ..but we actually want to pollute our namespace here

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list