[PATCH 6 of 9 hglib] hgclient: accept a single value for functions that take '-r'

Idan Kamara idankk86 at gmail.com
Thu Jul 28 14:58:59 CDT 2011


# HG changeset patch
# User Idan Kamara <idankk86 at gmail.com>
# Date 1311450939 -10800
# Node ID bc84a8ded1610a0497e0f32499d014e2d1f1c117
# Parent  1a84d5a142ffe6e40f96cb96f4beb9a346d4fa78
hgclient: accept a single value for functions that take '-r'

i.e. repo.log(revset.branch('stable'))

diff -r 1a84d5a142ff -r bc84a8ded161 hglib/hglib.py
--- a/hglib/hglib.py	Sat Jul 23 22:55:39 2011 +0300
+++ b/hglib/hglib.py	Sat Jul 23 22:55:39 2011 +0300
@@ -191,20 +191,20 @@
 
         return d
 
-    def log(self, revrange=[]):
+    def log(self, revset=None):
         args = util.commandlinebuilder('log')
         args.arg('--template', [templates.changeset])
-        args.arg('-r', revrange)
+        args.argif(revset, '-r', revset)
 
         out = self.outputruncommand(args)[1]
         out = out.split('\0')[:-1]
 
         return changeset.fromtemplate(out)
 
-    def incoming(self, revrange=[], path=None):
+    def incoming(self, revset=None, path=None):
         args = util.commandlinebuilder('incoming')
         args.arg('--template', [templates.changeset])
-        args.arg('-r', revrange)
+        args.argif(revset, '-r', revset)
         args.argif(path, path)
 
         ret, out, err = self.outputruncommand(args, raiseonerror=False)
@@ -216,10 +216,10 @@
         else:
             raise error.CommandError(args, ret, out, err)
 
-    def outgoing(self, revrange=[], path=None):
+    def outgoing(self, revset=None, path=None):
         args = util.commandlinebuilder('outgoing')
         args.arg('--template', [templates.changeset])
-        args.arg('-r', revrange)
+        args.argif(revset, '-r', revset)
         args.argif(path, path)
 
         ret, out, err = self.outputruncommand(args, raiseonerror=False)
@@ -239,7 +239,7 @@
 
         out = self.outputruncommand(args)[1]
         rev = out.split(':')[1]
-        return self.log(revrange=[rev])[0]
+        return self.log(revset=rev)[0]
 
     def import_(self, patch):
         args = util.commandlinebuilder('import')
@@ -261,11 +261,11 @@
         return self.outputruncommand(['root'])[1].rstrip()
 
     def clone(self, source='.', dest=None, branch=None, updaterev=None,
-              revrange=[]):
+              revset=None):
         args = util.commandlinebuilder('clone')
         args.argif(branch, '-b', branch)
         args.argif(updaterev, '-u', updaterev)
-        args.arg('-r', revrange)
+        args.argif(revset, '-r', revset)
 
         args.arg(source)
         args.argif(dest, dest)


More information about the Mercurial-devel mailing list