Top 5 open bugs for 1.9.1 (Monday!)

[Adrian Buehlmann]

On 2011-07-30 11:31, Adrian Buehlmann wrote:
> On 2011-07-30 11:00, Adrian Buehlmann wrote:
>> On 2011-07-30 10:38, Adrian Buehlmann wrote:
>>> On 2011-07-30 01:13, Matt Mackall wrote:
>>>> Here are the 5 bugs I'd like to get closed before Monday's release:
>>>>
>>>> status -q no longer overrides hgrc setting
>>>> hgweb raw view on HTML allows cross-site scripting (issue2923)
>>>> qimport url with queries is broken (issue2921)
>>>
>>> ..
>>>
>>>> TortoiseHG passes pseudo filehandles (THG #937)
>>>
>>> I did want to have a look at this one, if Steve doesn't beat me to (he
>>> seems to be pretty busy with other things).
>>>
>>> Idan pasted a diff for mercurial on that thg issue entry.
>>
>> Interesting.
>>
>> I fail to repro THG #937 when running from TortoiseHg stable source
>> revision d533e14e006b using mercurial stable source revision 192e02680d09.
>>
>> I thus closed #937.
> 
> Oh well. I was celebrating too early.
> 
> The bug is present in thg as installed from a binary recent stable
> installer build
> 
> "TortoiseHg version 2.1.1+113-d4016fbb0777
> with Mercurial-1.9+35-56848e2bb0c5, Python-2.6.6, PyQt-4.8.3, Qt-4.7.1"
> 
> Reopening.
> 
> (sorry for the noise)

Interestingly enough, the traceback in TortoiseHg is "AttributeError:
'Blackhole' object has no attribute 'fileno'".

We have no "Blackhole" object (with that exact spelling) anywhere in the
TortoiseHg or Mercurial sources.

But py2exe (http://www.py2exe.org/) has in boot_common.py:

http://py2exe.svn.sourceforge.net/viewvc/py2exe/trunk/py2exe/py2exe/boot_common.py?revision=688&view=markup

    class Blackhole(object):
        softspace = 0
        def write(self, text):
            pass
        def flush(self):
            pass
    sys.stdout = Blackhole()