[PATCH] mq: add -d/--delete option to qpop that deletes after popping

Mads Kiilerich mads at kiilerich.com
Wed Jun 8 18:28:17 CDT 2011


Kevin Bullock wrote, On 06/04/2011 06:33 AM:
> On 2 Jun 2011, at 5:14 PM, Mads Kiilerich wrote:
>
>> Matt Mackall wrote, On 06/02/2011 09:26 PM:
>>> On Thu, 2011-06-02 at 14:07 -0500, Kevin Bullock wrote:
>>>> On Jun 2, 2011, at 11:17 AM, Idan Kamara wrote:
>>>>
>>>>> # HG changeset patch
>>>>> # User Idan Kamara<idankk86 at gmail.com>
>>>>> # Date 1307031405 -10800
>>>>> # Node ID 970d8d9b69004d550ec5e33f529de118033047ab
>>>>> # Parent  30506b89435921bf2e7622613044cca2acab4196
>>>>> mq: add -d/--delete option to qpop that deletes after popping
>>>> I'm -1 on this one on the grounds of the Command-Line Option Non-Proliferation Treaty.
>>> Agreed.
>> I have been using a patch that does something similar but as qrm -f - based on http://markmail.org/message/3vilvesb6wn433ui .
>>
>> The force option is already used on a lot of commands, and I think the obvious behaviour for qrm with force on an applied patch is to pop it and remove it. FWIW I think that is consistency, not proliferation.
> That doesn't strike me as obvious behavior at all. If anything, I'd expect a qrm --force to leave the commit but remove the patch file... but we wouldn't actually want to allow that,

That is what 'qrm -r patchname' does, so -f would have to do something 
else ;-)

> so I'm not sure there exists any sensible behavior for qrm --force.

In my opinion the sensible behavior when removing something with force 
is to "unmount" it by all means and then remove it.

/Mads


More information about the Mercurial-devel mailing list