[PATCH 2 of 2] sslutil: Only emit debug log messages accessing https repo on python2.4+2.5
Matt Mackall
mpm at selenic.com
Tue Jun 14 18:47:58 CDT 2011
On Wed, 2011-06-15 at 01:29 +0200, Mads Kiilerich wrote:
> Matt Mackall wrote, On 06/14/2011 10:07 PM:
> >>> diff --git a/mercurial/sslutil.py b/mercurial/sslutil.py
> >>> --- a/mercurial/sslutil.py
> >>> +++ b/mercurial/sslutil.py
> >> ...
> >>> - else: # python 2.5 ?
> >>> - if hostfingerprint:
> >>> - raise util.Abort(_('no certificate for %s with '
> >>> - 'configured hostfingerprint') % host)
> >> A simple solution could be to change this message to something like
> >> "configured hostfingerprint for %s can't be verified because of missing
> >> Python SSL capabilities" ... only shorter.
> > "host fingerprint for %s can't be verified (upgrade Python)"?
> Users on these old Pythons are probably in a situation where upgrading
> Python isn't an option, so it might be a bad advice that annoys them so
> much that they miss the point. But I think this is the best suggestion
> we have seen so far.
Well "(Python too old)" also works, and is more a commiseration than an
admonishment.
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel
mailing list