[PATCH] patch: fix typo in variable name

timeless timeless at gmail.com
Mon Jun 20 10:25:01 CDT 2011


In theory we have pyflakes, but this requires you to have pyflakes installed.

I'm not running pyflakes regularly nor am I actively working on Mercurial.

On 6/20/11, Peter Arrenbrecht <peter.arrenbrecht at gmail.com> wrote:
> On Mon, Jun 20, 2011 at 9:30 AM, Peter Arrenbrecht
> <peter.arrenbrecht at gmail.com> wrote:
>> # HG changeset patch
>> # User Peter Arrenbrecht <peter.arrenbrecht at gmail.com>
>> # Date 1308555003 -7200
>> # Branch stable
>> # Node ID 556da009286f65dd10d61c52636e1a5bc55fde0c
>> # Parent  15faf0e66909286e9ca88f536a160db1d2fc6aac
>> patch: fix typo in variable name
>>
>> diff --git a/mercurial/patch.py b/mercurial/patch.py
>> --- a/mercurial/patch.py
>> +++ b/mercurial/patch.py
>> @@ -1378,7 +1378,7 @@
>>             cwd = repo.getcwd()
>>             if cwd:
>>                 cfiles = [util.pathto(repo.root, cwd, f)
>> -                          for f in cfile]
>> +                          for f in cfiles]
>>             scmutil.addremove(repo, cfiles, similarity=similarity)
>>     code = fp.close()
>>     if code:
>>
>
> By the way, Eclipse's PyDev tells me this kind of stuff using static
> analysis. Don't we have something like this running (pylint or
> something)?
> -parren
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>

-- 
Sent from my mobile device


More information about the Mercurial-devel mailing list