test-duplicateoptions, inotify (was: test-subrepo-svn.t fails)

[Idan Kamara]

On Wed, Jun 22, 2011 at 12:32 PM, Christian Ebert <blacktrash at gmx.net> wrote:
> * Idan Kamara on Wednesday, June 22, 2011 at 11:13:02 +0300
>> On Wed, Jun 22, 2011 at 10:56 AM, Christian Ebert <blacktrash at gmx.net> wrote:
>>> $ ./run-tests.py --local test-duplicateoptions.py
>>>
>>> --- /Users/chris/src/hg/tests/test-duplicateoptions.py.out
>>> +++ /Users/chris/src/hg/tests/test-duplicateoptions.py.err
>>> @@ -0,0 +1 @@
>>> +*** failed to import extension inotify: No module named inotify
>>>
>>> ERROR: /Users/chris/src/hg/tests/test-duplicateoptions.py output changed
>>> !
>>> Failed test-duplicateoptions.py: output changed
>>> # Ran 1 tests, 0 skipped, 1 failed.
>>
>> Did you compile inotify?
>
> No. I'm on a Mac, and just did "make local" for run-tests -l. And
> inotify is not compiled because my machine lacks the inotify
> requirements:

Ah, well that's possible too.

>
> $ ./run-tests.py -l test-inotify.t
> s
> Skipped test-inotify.t: missing feature: inotify extension support
> # Ran 0 tests, 1 skipped, 0 failed.
>
>> If I delete hgext/inotify/linux/_inotify.so I get the same error.
>>
>>>
>>> succeeds without --local:
>>
>> Probably because it compiles it.
>
> No, it more looks like the local test does not detect/handle the
> missing inotify.

Well, the test is simply loading all disabled extensions from your
local dir, where it finds inotify even though it's not compiled.

My guess is that when running 'make' where inotify isn't supported,
it doesn't create its directory in hgext when creating the test installation,
thus not listing it as a disabled extension.

>
> c
> --
> theatre - books - texts - movies
> Black Trash Productions at home: http://www.blacktrash.org
> Black Trash Productions on Facebook:
> http://www.facebook.com/blacktrashproductions
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>