[PATCH] opener: add self._audit (issue2862)

Adrian Buehlmann adrian at cadifra.com
Wed Jun 22 15:25:25 CDT 2011


On 2011-06-22 22:05, Matt Mackall wrote:
> On Wed, 2011-06-22 at 11:35 +0200, Adrian Buehlmann wrote:
>> On 2011-06-22 10:54, Idan Kamara wrote:
>>> On Wed, Jun 22, 2011 at 11:39 AM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>>>> # HG changeset patch
>>>> # User Adrian Buehlmann <adrian at cadifra.com>
>>>> # Date 1308730424 -7200
>>>> # Node ID 348c9f997718f66661190e1640db5b51c12a76e4
>>>> # Parent  8deebb5777511369a852e5cb42e69844c40ebf7a
>>>> opener: add self._audit (issue2862)
>>>
>>> It might have been nicer to see a longer commit message
>>> describing how this actually fixes the issue. Because for
>>> someone (like myself) who didn't investigate this bug report,
>>> it's hard to understand what's going on.
>>
>> Yeah. Perhaps I've been a bit too long in this opener business to do yet
>> another rain dance here.
>>
>> Plus wasting time on messages on patches that potentially get refused
>> anyway isn't that funny. So at times I get lazy and just try without yet
>> another cliff notes that probably no one wants to read anyway. I didn't
>> expect that GSOC students are interested in scrutinizing patches that
>> fix issues in contrib which affect Windows only.
> 
> I've insisted that GSOC students involve themselves in the community
> aspects of the project just like a normal contributor, including
> scrutinizing other people's patches.
> 

That's cool. Especially if they care about Windows issues.

Let me know if you need a better change message for the patch in order
to push it.


More information about the Mercurial-devel mailing list