[PATCH 1 of 2 stable] run-tests: fallback to SIGTERM if subprocess.Popen does not have terminate()

Thomas Arendsen Hein thomas at intevation.de
Thu Jun 30 14:34:42 CDT 2011


* Matt Mackall <mpm at selenic.com> [20110630 21:13]:
> On Thu, 2011-06-30 at 16:39 +0200, Thomas Arendsen Hein wrote:
> > # HG changeset patch
> > # User Thomas Arendsen Hein <thomas at intevation.de>
> > # Date 1309443905 -7200
> > # Branch stable
> > # Node ID c7991244cf89756e74aa34c8a1178031ca8e4d4d
> > # Parent  7ba7459875cb139ab996412b99d4a6c9dec0041f
> > run-tests: fallback to SIGTERM if subprocess.Popen does not have terminate()
> 
> Let's wait on this until Monday.

For 1.9.1 (since it fixes a kind of regression from 1.8) or for 1.10?

I think this is a trivial bugfix since it does not change the
situation for Pythons having terminate and even if it somehow causes
a traceback on other platforms this would be no change from the
current behavior. Therefore I would suggest 1.9.1.

Regards,
Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial-devel mailing list