[PATCH] eol: hook should consider all changegroup heads (issue2666)

Antoine Pitrou solipsis at pitrou.net
Tue Mar 1 10:57:05 CST 2011


On Tue, 01 Mar 2011 17:20:24 +0100
Martin Geisler <mg at aragost.com> wrote:
> 
> I was just about to push this, but then I changed my mind... I wrote
> this to Antoine on IRC:
> 
> Hi again -- I just convinced myself that the patch to make eol.hook
> check all heads is wrong. We cannot use the encode/decode filters found
> in the current ui since they are read from tip they should be read from
> the .hgeol file in each head to be correct

True. But the fact that this patch extracts the current heads is a step
in the right direction :)

> The same goes for the allcsethook patch.

Indeed.

> I suggest we wait with these patches until after the release and then
> refactor the eol extension heavily -- the readhgeol method should be a
> function so that the hook(s) can call it to read the .hgeol file from
> whatever revision they like without setting global state.
> 
> Does that sound okay?

I haven't looked in detail, but on the principle it sounds sane.

Regards

Antoine.


More information about the Mercurial-devel mailing list