[issue2670] test-hup test can lose a race

timeless bugs at mercurial.selenic.com
Tue Mar 1 22:14:33 UTC 2011


New submission from timeless <timeless at gmail.com>:

i tried running the tests on one of my machines (it's probably a vm). i
don't have the output here, but i think i can reach it tomorrow if i bring
my bts credentials.

anyway, the script expects to do this:
$ kill -HUP $P
$ wait
transaction abort!
rollback completed
killed!

the output was (from memory)

 $ kill -HUP $P
-$ wait
 transaction abort!
 rollback completed
+$ wait
 killed!

i believe that there's no requirement for the kill to be so async and slow
such that the output from kill doesn't happen before the wait command is
executed.

i believe the right thing to do is:

 $ kill -HUP $P & wait

----------
messages: 15460
nosy: timeless
priority: bug
status: chatting
title: test-hup test can lose a race

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue2670>
____________________________________________________


More information about the Mercurial-devel mailing list