[PATCH] httprepo: use caps instead of between for compat check

Augie Fackler durin42 at gmail.com
Sat Mar 12 14:52:40 CST 2011


On Mar 12, 2011, at 1:22 PM, Benoit Boissinot wrote:
> 
> On Sat, Mar 12, 2011 at 6:30 PM, Peter Arrenbrecht
> <peter.arrenbrecht at gmail.com> wrote:
>> # HG changeset patch
>> # User Peter Arrenbrecht <peter.arrenbrecht at gmail.com>
>> # Date 1299950942 -3600
>> httprepo: use caps instead of between for compat check
>> 
>> We usually query the capabilities at some point anyway so this way the first roundtrip
>> actually does useful work.
> 
> Queued, thanks!

What happens when the server responds with garbage that isn't a valid capabilities list? Do we abort with some silly unsupported capability? What would happen if we tried talking to a newer server and it required a capability we lack locally?

> 
> Benoit
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel




More information about the Mercurial-devel mailing list