[PATCH RFC] HGPLAIN: allow exceptions to plain mode, like i18n, via HGPLAINEXCEPT

Matt Mackall mpm at selenic.com
Mon Mar 14 13:41:20 CDT 2011


On Sun, 2011-03-13 at 18:35 -0400, Brodie Rao wrote:
> On Jan 5, 2011, at 5:46 PM, Brodie Rao wrote:
> 
> > On Jan 6, 2011, at 9:40 AM, Matt Mackall wrote:
> >
> >> On Wed, 2011-01-05 at 00:21 +1100, Brodie Rao wrote:
> >>> # HG changeset patch
> >>> # User Brodie Rao <brodie at bitheap.org>
> >>> # Date 1294147116 -39600
> >>> # Node ID b653ec8e753a01653d46c70c56e72a37f5906f58
> >>> # Parent  f3058dd052819de75908599d93a29241ba69318f
> >>> HGPLAIN: allow exceptions to plain mode, like i18n, via  
> >>> HGPLAINEXCEPT
> >>
> >> This wasn't what we decided on at the sprint, which just used the
> >> contents of HGPLAIN.
> >
> > Sorry, I should've explained that addition.
> >
> > Henrik and I were discussing the patch on IRC, and I came to the  
> > conclusion that using HGPLAIN to specify exceptions felt backwards.  
> > Just looking at "HGPLAIN=i18n,foo,bar" by itself, I can't tell if  
> > it's listing exceptions or if it's listing the things I want to  
> > disable. I think HGPLAINEXCEPT is clearer.
> >
> > That said, I don't feel that strongly about it. Overloading HGPLAIN  
> > would be OK with me.
> 
> Does anyone have any opinions about this change? Should I go back to  
> overloading HGPLAIN? I'd like to get this into default for 1.9.

You can resend your HGPLAINEXCEPT version.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list