[PATCH] setup: fix mac build broken by e42d18538e1d

Greg Ward greg at gerg.ca
Sun Mar 13 21:26:24 CDT 2011

On 13 March 2011, Jon M. Dugan said:
> # HG changeset patch
> # User Jon M. Dugan <jdugan at x1024.net>
> # Date 1300055973 18000
> # Branch stable
> # Node ID 27e8d0c69f6f3cc657885bd4d3fe6e19e39ab791
> # Parent  71a96f6c205dcbfbe6a770d11133cc9447f3351b
> setup: fix mac build broken by e42d18538e1d
> Sometimes xcodebuild prints warnings to stderr, but runcmd() assumes anything
> printed to stderr implies failure.  Since runcmd() was originally only
> intended to run hg, this was fine until it was pressed into service for
> running xcodebuild.  Thus: split runcmd() into two parts: runcmd(), which does
> the minimal amount of work to run a subprocess, and runhg(), which calls
> runcmd().

First patch from the sprint at PyCon!  This patch was reviewed in person
by Brodie and me; works on OS X 10.5.  Not tested with XCode 4.0, the
version that motivated the change that broke things.

Greg Ward                                http://www.gerg.ca/
Jesus Saves -- but Moses gets the rebound, he shoots, he SCORES!

More information about the Mercurial-devel mailing list