[PATCH] graphlog: add revsets support (and convert usual options to revset)

Matt Mackall mpm at selenic.com
Wed Mar 16 17:30:50 CDT 2011


On Wed, 2011-03-16 at 23:27 +0100, Alexander Solovyov wrote:
> On Wed, Mar 16, 2011 at 23:21, Matt Mackall <mpm at selenic.com> wrote:
> > On Tue, 2011-03-15 at 09:30 +0100, Alexander Solovyov wrote:
> >> # HG changeset patch
> >> # User Alexander Solovyov <alexander at solovyov.net>
> >> # Date 1300028018 -3600
> >> # Node ID 8f29edb674ab941f03b11d542aeceb71fcbd6de8
> >> # Parent  595dba23d33780a5f2752a837898861704ef18bf
> >> graphlog: add revsets support (and convert usual options to revset)
> >
> > Is this the version of the patch I queued yesterday that actually passes
> > tests?
> 
> Well, actually it does, but this makes one change to behavior - if
> changeset has two parents, which should end in same grandparent, it
> draws only single line. Not only this makes sense, but format for
> console drawer has no notion how to draw line which is forked and
> merged in a single segment. So previous version will draw line for
> second parent from nowhere (from null revision).
> 
> Not sure why I haven't added another test. Probably please postpone
> pushing this patch, I'll resend new version with test which checks
> this behavior.

Ok, neither version passes tests here. This one fails with:

@@ -1113,16 +1113,9 @@
 
 Unused arguments:
   $ hg glog -q foo bar
-  hg glog: invalid arguments
-  hg glog [OPTION]... [FILE]
-  
-  show revision history alongside an ASCII revision graph
-  [255]
 
 Only one file is allowed:
   $ hg log -G foo bar
-  abort: --graph option allows at most one file
-  [255]
 
 Empty revision range - display nothing:
   $ hg glog -r 1..0


Failed test-glog.t: output changed
Failed test-debugbuilddag.t: output changed

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list