[PATCH] cmdutil: fix mode handling in make_file

Adrian Buehlmann adrian at cadifra.com
Sat Mar 26 14:08:33 CDT 2011


# HG changeset patch
# User Adrian Buehlmann <adrian at cadifra.com>
# Date 1298500248 -3600
# Node ID b75d52318b2ab88d223983b5c901d80b54552351
# Parent  0f9282dc87f8e2ac5f0ad988cb556657d65127c1
cmdutil: fix mode handling in make_file

diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -230,7 +230,7 @@ def make_filename(repo, pat, node,
 def make_file(repo, pat, node=None,
               total=None, seqno=None, revwidth=None, mode='wb', pathname=None):
 
-    writable = 'w' in mode or 'a' in mode
+    writable = mode not in ('r', 'rb')
 
     if not pat or pat == '-':
         fp = writable and sys.stdout or sys.stdin


More information about the Mercurial-devel mailing list