[PATCH 11 of 11 RFC] url: refactor util.drop_scheme() and hg.localpath() into url.localpath()

Brodie Rao brodie at bitheap.org
Mon Mar 28 20:30:57 CDT 2011


(CCing this back to the list...)

On Mon, Mar 28, 2011 at 7:23 AM, Aaron Cohen <aaron at assonance.org> wrote:
> On Sat, Mar 26, 2011 at 2:29 AM, Brodie Rao <brodie at bitheap.org> wrote:
>> # HG changeset patch
>> # User Brodie Rao <brodie at bitheap.org>
>> # Date 1301119907 25200
>> # Node ID 0d6a6ff7d3c7703672f40ed994b721ecd51e0222
>> # Parent  79716c21ef9a7816d71fc8da1b6a3dd051d507bb
>> url: refactor util.drop_scheme() and hg.localpath() into url.localpath()
>>
>
> Hi Brodie,
>
>   As the author of
> http://mercurial.selenic.com/wiki/Win32LongFileNamesExtension it's
> obviously on me to accomodate any changes you're making here, but if
> possible I'd like to be sure your patch doesn't break my stuff too
> badly.
>
>    I will find some time to take a look myself later, but would it be
> possible for you to add a row to your table for something like:
> file:////server/share/foo (on Windows, this is a "UNC" share name and
> is equivalent to \\server\share\foo)?

FWIW, here's what it does now:

>>> url(r'file:////server/share/foo')
<url scheme: 'file', path: '//server/share/foo'>
>>> url(r'//server/share/foo')
<url path: '//server/share/foo'>

>   I'm not entirely sure what the impact of this will be on my
> extension, but I think that I should be fine if I cross my fingers
> hard enough. Is playing with bundles the best way of testing this?
>

You could "hg pull" from a repo on a share using UNC syntax.


More information about the Mercurial-devel mailing list