[PATCH 1 of 5] bugzilla: rename filter_unknown_bug_ids to reflect its actual purpose

Jim Hague jim.hague at acm.org
Wed Mar 30 03:54:17 CDT 2011


# HG changeset patch
# User Jim Hague <jim.hague at acm.org>
# Date 1301474985 -3600
# Node ID 414a4bc47ce5e062db657c8fe8973fce34d29935
# Parent  307c72686eb0c336db0e20143a76edb211e9bba8
bugzilla: rename filter_unknown_bug_ids to reflect its actual purpose.

The method really removes from the list of bugs any that already have
comment text referencing the changeset in question. Rename it to
filter_cset_known_bug_ids().

diff --git a/hgext/bugzilla.py b/hgext/bugzilla.py
--- a/hgext/bugzilla.py
+++ b/hgext/bugzilla.py
@@ -194,7 +194,7 @@
         self.run('select bug_id from bugs where bug_id in %s' % buglist(ids))
         return sorted([c[0] for c in self.cursor.fetchall()])
 
-    def filter_unknown_bug_ids(self, node, ids):
+    def filter_cset_known_bug_ids(self, node, ids):
         '''filter bug ids from list that already refer to this changeset.'''
 
         self.run('''select bug_id from longdescs where
@@ -376,7 +376,7 @@
         if ids:
             ids = self.filter_real_bug_ids(ids)
         if ids:
-            ids = self.filter_unknown_bug_ids(ctx.node(), ids)
+            ids = self.filter_cset_known_bug_ids(ctx.node(), ids)
         return ids
 
     def update(self, bugid, ctx):


More information about the Mercurial-devel mailing list