[issue2743] hg push --mq uses parent repository default path if patch repos hgrc does not define it

Faheem Mitha bugs at mercurial.selenic.com
Thu Mar 31 14:03:23 CDT 2011


New submission from Faheem Mitha <faheem at email.unc.edu>:

If the patch repository does not define the default path in its hgrc, then 
the following output is produced on push and pull. The pull output seems 
correct to me, the push output is clearly wrong, as it is using the parent's 
default path. This should be easy to reproduce, so I'm giving a test case.

BTW, I don't see why `hg push --mq` and similar commands can't just 
manufacture the necessary path by appending /.hg/patches to the default 
path, if the patch repository doesn't define it. I can't see how that would 
be a security issue either. I could make this a wishlist but, but maybe 
there is some reason I am missing why this is undesirable.

hg-hg corresponds to http://selenic.com/hg/, with tip

changeset:   13827:f1823b9f073b
tag:         tip
user:        Matt Mackall <mpm at selenic.com>
date:        Thu Mar 31 10:43:53 2011 -0500
summary:     url: nuke some newly-introduced underbars in identifiers

faheem at orwell:~/bixproj$ hg-hg -v push --mq
pushing to ssh://bulldog_hg//srv/hg/faheem/bixproj
running ssh -C bulldog_hg "hg -R /srv/hg/faheem/bixproj serve --stdio"
searching for changes
searching [  <=>                                                                                                                                                    
] 2abort: repository is unrelated
faheem at orwell:~/bixproj$ hg-hg -v pull --mq
abort: repository default not found!

----------
messages: 15932
nosy: faheem
priority: bug
status: unread
title: hg push --mq uses parent repository default path if patch repos hgrc does not define it

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue2743>
____________________________________________________


More information about the Mercurial-devel mailing list