[PATCH 1 of 2] store: refactor fncacheopener into a class

Adrian Buehlmann adrian at cadifra.com
Thu Mar 31 15:40:34 CDT 2011


On 2011-03-31 21:12, Matt Mackall wrote:
> On Thu, 2011-03-31 at 20:05 +0200, Adrian Buehlmann wrote:
>> # HG changeset patch
>> # User Adrian Buehlmann <adrian at cadifra.com>
>> # Date 1301588551 -7200
>> # Node ID 59407bbe840ae49ecc0823dd7d0acf8e731fca2f
>> # Parent  f1823b9f073bd376e19fc544c2891609458891e4
>> store: refactor fncacheopener into a class
> 
> I get the impression that you're doing this because I said something
> like "these things should be real classes". 

Not exactly.

> But the reason to use a class is to take advantage of inheritance. Then
> when we add features/attributes at the bottom of the stack, they're
> automatically available at the top. With inheritance-through-wrapping,
> you don't get this.

One of your usual puzzles.

But I give up this definitely now. There's seems to be no interest in
cleaning up these things from your side.



More information about the Mercurial-devel mailing list