[PATCH v3] httprepo: long arguments support (issue2126)

Sune Foldager cryo at cyanite.org
Sun May 1 03:16:47 CDT 2011


On 30-04-2011 19:55, Matt Mackall wrote:
> On Sun, 2011-05-01 at 01:07 +0800, Steven Brown wrote:
>> # HG changeset patch
>> # User Steven Brown<StevenGBrown at gmail.com>
>> # Date 1304183077 -28800
>> # Node ID 6024fa2a1049c4759f4d4ee95cc44662a8cf2faa
>> # Parent  305c97670d7a6f89897e2b3a3076895fbc1a29f6
>> httprepo: long arguments support (issue2126)
>
> Looks great, queued. I'm going to make two changes:
>
> 1) X-Args-1 ->  X-HgArg-1
> 2) itertools.count(1) to a while loop with an incrementer

It's nice, but maybe we should consider only activating the feature when 
the argument line is longer than some set limit. It's often convenient 
to debug wire stuff by looking at the request lines, and having 
arguments in headers unconditionally makes this harder.

/Sune


More information about the Mercurial-devel mailing list