[PATCH 1 of 4] opener: introduce an abstact superclass of it

Adrian Buehlmann adrian at cadifra.com
Sun May 1 04:17:12 CDT 2011

On 2011-05-01 10:50, Matt Mackall wrote:
> On Sun, 2011-05-01 at 08:44 +0200, Dan Villiom Podlaski Christiansen
> wrote:
>> # HG changeset patch
>> # User Dan Villiom Podlaski Christiansen <danchr at gmail.com>
>> # Date 1304185008 -7200
>> # Node ID 5f957e0a8434bcdfdb7d414273381da904fe2c43
>> # Parent  439271cd151f7e1ed9e60fe8bbc5ec0f2fb0f5c5
>> opener: introduce an abstact superclass of it
>> Currently, this class doesn't do anything useful.
> This set is more or less what I was looking for, queued. Adrian, if this
> duplicates what you'd done earlier, I'm sorry if I misread it.

My tactical error was that I didn't even get to the step of introducing
the base case. I was shot down in my initial patches that turned the
existing openers into classes [1]. I didn't even remotely made it to the
point of showing you my last step, which derived all of them from the
abstract base.

(Lesson learned: always send the full series.)

[1] http://selenic.com/pipermail/mercurial-devel/2011-March/029666.html

More information about the Mercurial-devel mailing list