[PATCH] wireproto: use base64 instead of hex for known/getbundle

Sune Foldager cryo at cyanite.org
Tue May 3 03:31:42 CDT 2011

On Tue, May 03, 2011 at 10:05:46AM +0200, Martin Geisler wrote:


> The commit message says "Saves a couple of bytes per node id being sent
> across the wire." but doesn't explain why this is necessary and why the
> cost of doing so pays off -- I'm not convinced that this is worth the
> extra complexity and obscurity.
> Firstly, being able to see the node IDs directly in the log file has
> some value. Having to base64 decode a log makes it much less useful.

I agree; I don't think we should do this and lose the ability to see the nodes.
(On the other hand, it's not so easy to see the nodes anymore, when they are
in HTTP headers, but it can be done.)


More information about the Mercurial-devel mailing list