[PATCH] wireproto: use base64 instead of hex for known/getbundle

[Augie Fackler]

On May 3, 2011, at 3:31 AM, Sune Foldager wrote:
> 
> On Tue, May 03, 2011 at 10:05:46AM +0200, Martin Geisler wrote:
> 
> [...]
> 
>> The commit message says "Saves a couple of bytes per node id being sent
>> across the wire." but doesn't explain why this is necessary and why the
>> cost of doing so pays off -- I'm not convinced that this is worth the
>> extra complexity and obscurity.
>> 
>> Firstly, being able to see the node IDs directly in the log file has
>> some value. Having to base64 decode a log makes it much less useful.
> 
> I agree; I don't think we should do this and lose the ability to see the nodes.
> (On the other hand, it's not so easy to see the nodes anymore, when they are
> in HTTP headers, but it can be done.)

I was actually going to ask if we could leave the arguments in the GET line if the resulting request line would be < 512 bytes (or some other arbitrary but reasonable value.) Would anyone object to such a tweak?

> 
> Sune
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel