[PATCH] wireproto: use base64 instead of hex for known/getbundle

Sune Foldager cryo at cyanite.org
Tue May 3 08:17:55 CDT 2011


On Tue, May 03, 2011 at 03:12:16 +0200, Sune Foldager wrote:
>On Tue, May 03, 2011 at 08:02:31 -0500, Augie Fackler wrote:
>>On May 3, 2011, at 3:31 AM, Sune Foldager wrote:
>>>
>>>I agree; I don't think we should do this and lose the ability to see the nodes.
>>>(On the other hand, it's not so easy to see the nodes anymore, when they are
>>>in HTTP headers, but it can be done.)
>>
>>I was actually going to ask if we could leave the arguments in the GET line if the resulting request line would be < 512 bytes (or some other arbitrary but reasonable value.) Would anyone object to such a tweak?
>
>I suggested it to Matt at the sprint, but it seems he forgot (or silently disagreed ;-)); I'd like that too, to ease debugging. In fact something like this should do it:
>
>(ALTHOUGH TESTS ARE NOT UPDATED, SO DON'T PUSH :p)

...but I'll fix those up as needed if people are ok with this and we can agree on a value :)

-Sune


More information about the Mercurial-devel mailing list