[PATCH] wireproto: use base64 instead of hex for known/getbundle

Matt Mackall mpm at selenic.com
Tue May 3 10:17:22 CDT 2011


On Tue, 2011-05-03 at 16:46 +0200, Sune Foldager wrote:
> On Tue, May 03, 2011 at 09:27:33AM -0500, Matt Mackall wrote:
> >On Tue, 2011-05-03 at 15:12 +0200, Sune Foldager wrote:
> >>
> >> # HG changeset patch
> >> # User Sune Foldager <cryo at cyanite.org>
> >> # Date 1304428122 -7200
> >> # Node ID 0cbcb62dd7679e2f8577679775c52ff79709b446
> >> # Parent  d8ba6fb2ce15add4937ce9c3710e8dbd99648818
> >> httprepo: only activate longargs for >512 byte arguments
> >>
> >> diff -r d8ba6fb2ce15 -r 0cbcb62dd767 mercurial/httprepo.py
> >> --- a/mercurial/httprepo.py     Sun May 01 13:08:29 2011 -0500
> >> +++ b/mercurial/httprepo.py     Tue May 03 15:08:42 2011 +0200
> >> @@ -78,7 +78,7 @@
> >>           self.ui.debug("sending %s command\n" % cmd)
> >>           q = [('cmd', cmd)]
> >>           headersize = 0
> >> -        if len(args) > 0:
> >> +        if len(args) > 512:
> >>               httpheader = self.capable('httpheader')
> >>               if httpheader:
> >>                   headersize = int(httpheader.split(',')[0])
> >
> >My concern here is that we want to make sure the new mode is heavily
> >field-tested. If it only triggers for pathological cases, that won't
> >happen.
> 
> Makes sense... we could also make a config option (on the server), and
> have it send both max and min size (it already sends max now).. might be
> a bit excessive, though.

Probably just want a way to turn it off entirely on the server for
debugging.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list