[PATCH] add positional arguments to non-shell aliases

Matt Mackall mpm at selenic.com
Tue May 3 15:37:38 CDT 2011


On Sun, 2011-05-01 at 14:37 +0200, Alexander Solovyov wrote:
> # HG changeset patch
> # User Alexander Solovyov <alexander at solovyov.net>
> # Date 1304245772 -7200
> # Node ID 55349a878c79c8893500fe0b9560265ea06fd659
> # Parent  0386b51dd749f83e3f759a5b799ec364924e3b82
> add positional arguments to non-shell aliases

A little worried about this one:

> +import pipes
...
> +        cmd = ' '.join(map(pipes.quote, args))

We don't use this module anywhere else, and this function isn't
documented here:

 http://docs.python.org/library/pipes.html#module-pipes

Also that says:

 Platforms: Unix

which is probably a show-stopper.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list