[PATCH RFC] hgweb: add config option for maxhttpheadersize

Sune Foldager cryo at cyanite.org
Wed May 4 11:56:25 CDT 2011


On Wed, May 04, 2011 at 11:45:49 +0800, Steven Brown wrote:
>On 4 May 2011 04:47, Sune Foldager <cryo at cyanite.org> wrote:
>> Does this look good to you? Setting it to 0, the new arguments-in-headers
>> option can then be disabled, for debug or other purposes.
>>
>> -Sune
>
>Yeah generally looks good. This is what I had in mind for a config option.
>
>Comments:
>- Why the "server" section, rather than "web" ?

Yeah, true... since it's only http, it should be in web.

>- The tests are a little strange to read. I'd prefer see HGPORT1 with
>error1.log, access1.log, and so on.

Myeah but blame those who defined HGPORT, HGPORT1 and HGPORT2 :p.
But I'll just name them access0.log etc. to fix it :)

>- Another test case would be a non-zero and non-default option, e.g.
>10 characters.

Right, I'll look at it. Thanks.

-Sune


More information about the Mercurial-devel mailing list