[PATCH] bundlerepo: fix closing and docstring of getremotechanges
Peter Arrenbrecht
peter.arrenbrecht at gmail.com
Wed May 4 13:15:04 CDT 2011
# HG changeset patch
# User Peter Arrenbrecht <peter.arrenbrecht at gmail.com>
# Date 1304532870 -7200
bundlerepo: fix closing and docstring of getremotechanges
I did not in fact implement what I documented about closing of the
original repo. And there was a bit of leftover from an older version
of the API.
diff --git a/mercurial/bundlerepo.py b/mercurial/bundlerepo.py
--- a/mercurial/bundlerepo.py
+++ b/mercurial/bundlerepo.py
@@ -295,7 +295,8 @@
"onlyheads" restricts the returned changes to those reachable from the
specified heads.
"bundlename", if given, stores the bundle to this file path permanently;
- the returned "bundle" will be None.
+ otherwise it's stored to a temp file and gets deleted again when you call
+ the returned "cleanupfn".
"force" indicates whether to proceed on unrelated repos.
Returns a tuple (local, csets, cleanupfn):
@@ -348,7 +349,7 @@
bundlerepo.close()
if bundle:
os.unlink(bundle)
- localrepo.close()
+ other.close()
return (localrepo, csets, cleanup)
More information about the Mercurial-devel
mailing list