[PATCHES] lwcopy-related

Sune Foldager cryo at cyanite.org
Thu May 5 02:24:45 CDT 2011


On Wed, May 04, 2011 at 07:54:44 +0200, Sune Foldager wrote:
>Two lwcopy-related patches. The first one adds a flags element to bundle
>chunks, which will come with the new bundle format, and used for lwcopy.

Scrap that one, my latest assessment is that I won't need a flag bit anyway
(hehe), IF we get generaldelta into the bundle format. Then we can actually
break chains, by setting base = nullnode, and this is enough for me to
detect the need for unpacking. But we'll see soon enough.

>The second one adds a file() function to filelog, so new filelogs can be
>opened without access to the repository object. This is needed later by
>lwcopy because bundlerepo needs to return its own filelog class.

Benoit and I discussed wether to pass on repo itself, or something simpler
like a lambda or simply the file() method. It's not very important IMO, as
it is an implementation detail that can be changed at any time. I personally
vote for passing in repo, for simplicity. As far as garbage collection goes,
it shouldn't make a difference either way. Benoit voted for passing in the
method.

-Sune


More information about the Mercurial-devel mailing list