[PATCH 2 of 3] color: style the changeset parents yellow too

Martin Geisler mg at aragost.com
Thu May 5 02:40:04 CDT 2011


Dan Villiom Podlaski Christiansen <danchr at gmail.com> writes:

> # HG changeset patch
> # User Dan Villiom Podlaski Christiansen <danchr at gmail.com>
> # Date 1304261814 -7200
> # Node ID 5df08ee62c531a8306ff9734b0ad848776463e54
> # Parent  1c8a84c0797a23092947efbe60d4ef63d5d9859d
> color: style the changeset parents yellow too
>
> diff --git a/hgext/color.py b/hgext/color.py
> --- a/hgext/color.py
> +++ b/hgext/color.py
> @@ -193,6 +193,7 @@ _styles = {'grep.match': 'red bold',
>             'diffstat.inserted': 'green',
>             'ui.prompt': 'yellow',
>             'log.changeset': 'yellow',
> +           'log.parent': 'yellow',
>             'resolve.resolved': 'green bold',
>             'resolve.unresolved': 'red bold',
>             'status.added': 'green bold',
> diff --git a/tests/test-log.t b/tests/test-log.t
> --- a/tests/test-log.t
> +++ b/tests/test-log.t
> @@ -558,8 +558,8 @@ log -p -l2 --color=always
>    \x1b[0;32m+postm\x1b[0m (esc)
>    
>    \x1b[0;33mchangeset:   5:302e9dd6890d\x1b[0m (esc)
> -  parent:      3:e62f78d544b4
> -  parent:      4:ddb82e70d1a1
> +  \x1b[0;33mparent:      3:e62f78d544b4\x1b[0m (esc)
> +  \x1b[0;33mparent:      4:ddb82e70d1a1\x1b[0m (esc)

No, no, this is bad :) The yellow lines are great now, they tell my eyes
where each changeset starts (and so there the preceding changeset ends).
I don't think we should change that.

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://mercurial.aragost.com/kick-start/


More information about the Mercurial-devel mailing list