deltaparent or deltabase; let's decide

Peter Arrenbrecht peter.arrenbrecht at gmail.com
Thu May 5 03:11:05 CDT 2011


On Thu, May 5, 2011 at 10:06 AM, Sune Foldager <cryo at cyanite.org> wrote:
> The concept of the parent or base of a delta, meaning the revision (or node)
> holding the text that a given delta is a patch for, is arbitrarily called
> deltaparent and deltabase throughout the code. We also have a related but
> separate concept 'base' in revlog, meaning the base of a chain of such
> deltas.
>
> We should decide on either deltaparent or deltabase, and change the code
> accordingly.
>
> Arguments in favor of deltabase include that it's the base of a delta.
> Arguments against is that it might conflate with the base of a delta CHAIN.
>
> Arguments in favor of deltaparent include that it's the parent of a delta
> ;-).
>
> What do you think?

+1 for deltaparent because of collision of deltabase with plain base.
-parren


More information about the Mercurial-devel mailing list