[PATCH] store: break up reference cycle introduced in 9cbff8a39a2a

Martin Geisler mg at aragost.com
Thu May 5 03:56:33 CDT 2011


Adrian Buehlmann <adrian at cadifra.com> writes:

> IIRC, we had some issues with memory usage going up (and staying) in
> the past (around that time when Simon made 996c1cd8f530).

Okay, that is of course unfortunate.

> I know that the Python GC is supposed to break up cycles. But I think
> if we can easily avoid cycles -- like in this case -- we should do it.
>
> If a data structure/algorithm provides some significant benefit by
> allowing cycles, then I agree with you.

Perfect, then we agree -- I just wanted to note the collection of cycles
in case someone was confused about it :)


-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://mercurial.aragost.com/kick-start/


More information about the Mercurial-devel mailing list