[PATCH] treediscovery: fix regression when running tests against older repos

Adrian Buehlmann adrian at cadifra.com
Thu May 5 06:05:07 CDT 2011


On 2011-05-05 12:55, Peter Arrenbrecht wrote:
> On Thu, May 5, 2011 at 12:48 PM, Peter Arrenbrecht
> <peter.arrenbrecht at gmail.com> wrote:
>> On Thu, May 5, 2011 at 12:40 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>>> On 2011-05-05 08:40, Peter Arrenbrecht wrote:
>>>> # HG changeset patch
>>>> # User Peter Arrenbrecht <peter.arrenbrecht at gmail.com>
>>>> # Date 1304577611 -7200
>>>> # Branch fix-push
>>>> # Node ID 03157a52465a8325cc4191ebdc499fbb91232946
>>>> # Parent  8968e4428dbd83836662612fc948d1b733c08354
>>>> treediscovery: fix regression when running tests against older repos
>>>>
>>>> I ran the entire test suite with "known" and "getbundle" disabled in
>>>> localrepository. This generated failures because the old findoutgoing
>>>> had always queried remote's heads explicitly and thus always got them
>>>> back in the returned heads. treediscovery.findcommonincoming now
>>>> correctly returns remote's heads in all cases.
>>>
>>> This fixes http://mercurial.selenic.com/bts/issue2793 for me, thanks!
>>>
>>> I suggest adding "(issue2793)" to the summary line.
>>>
>>> Maybe a testcase would be nice too? :-)
>>
>> Working on exactly that.
> 
> Sent new patch which replaces this one.

Awesome!



More information about the Mercurial-devel mailing list