[PATCH] upgrade casecollisionauditor to portabilityauditor

Adrian Buehlmann adrian at cadifra.com
Sat May 7 14:25:19 CDT 2011

On 2011-05-03 21:10, Kevin Gessner wrote:
> On Tue, May 3, 2011 at 3:02 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>> On 2011-05-02 19:55, Adrian Buehlmann wrote:
>>> # HG changeset patch
>>> # User Adrian Buehlmann <adrian at cadifra.com>
>>> # Date 1304343849 -7200
>>> # Node ID 663767d08c5193686b9672d0e5954526f335f572
>>> # Parent  d8ba6fb2ce15add4937ce9c3710e8dbd99648818
>>> upgrade casecollisionauditor to portabilityauditor
>>> - include calls to checkfilename and checkwinfilename in auditor
>>> - check filenames on rename/copy/addremove
>>> - scmutil.checkportable and checkportabilityalert are no longer needed
> I'm +1 this patch (other than the test failure noted below)

Thanks. But the failure is really horrible. Pretty lousy work from my
side. Sorry for the noise.

>> This patch is wrong for renames that change case
>>  adi at ubuntu1:~/tmp/a$ hg rename foo FOO
>>  warning: possible case-folding collision: 'FOO'
>> There should be no warning (or abort) in this case.
> It looks like portabilityauditor needs a way to remove items from its _map, yes?

Good idea. Might work. But it looks more complicated than I first
thought (as usual).

BTW: Thanks for your reply. Sorry for responding late here. I haven't
forgotten this one. In fact, I still spend a few of my lousy brain
cycles per day on this one. 1.9 code freeze is coming soon...

More information about the Mercurial-devel mailing list