[PATCH] util: rename _windows_reserved_filenames and _windows_reserved_chars

Sune Foldager cryo at cyanite.org
Sun May 8 01:57:34 CDT 2011

On 08-05-2011 00:29, Adrian Buehlmann wrote:
> On 2011-05-07 23:38, Sune Foldager wrote:
>> On 2011-05-07 23:07, Adrian Buehlmann wrote:
>>> # HG changeset patch
>>> # User Adrian Buehlmann<adrian at cadifra.com>
>>> # Date 1304799920 -7200
>>> # Node ID 4168febc29ffaee26de5cc1b1289454e4c85debf
>>> # Parent  fe2153fd0fe5de49790e82d8038f5e07dd502e63
>>> util: rename _windows_reserved_filenames and _windows_reserved_chars
>> I realize we have this no-underscore policy, which I don't agree with, but is
>> this really supposed to be an improvement?:
>>> -_windows_reserved_filenames = '''con prn aux nul
>>> +_winresnames = '''con prn aux nul
>> Res? Resource names?... this is the primary reason I am opposed to
>> no-underscores :p.
> Yeah. In *that* code, it is really hard see what _winresnames is
> supposed to be hmm? You even had to delete the interesting bits, to
> prove your point :-)

Well, I didn't claim to *prove* anything. I just don't like shortening 
such names just so they can look less ridiculous when you remove the 
underscores from them.

> Oh. Yeah. Let's see. And the function is called checkwinfilename. What
> the heck is win again. Hmmm.

Well, I think 'win' is a bit more established and unambiguous than 'res'.

> I'm sure the next email is coming from Martin :-)

Oh come on now... et tu?

More information about the Mercurial-devel mailing list