[PATCH] util: rename _windows_reserved_filenames and _windows_reserved_chars

[Steven Brown]

On 8 May 2011 05:38, Sune Foldager <cryo at cyanite.org> wrote:
> On 2011-05-07 23:07, Adrian Buehlmann wrote:
>>
>> # HG changeset patch
>> # User Adrian Buehlmann <adrian at cadifra.com>
>> # Date 1304799920 -7200
>> # Node ID 4168febc29ffaee26de5cc1b1289454e4c85debf
>> # Parent  fe2153fd0fe5de49790e82d8038f5e07dd502e63
>> util: rename _windows_reserved_filenames and _windows_reserved_chars
>
> I realize we have this no-underscore policy, which I don't agree with, but
> is
> this really supposed to be an improvement?:
>
>> -_windows_reserved_filenames = '''con prn aux nul
>> +_winresnames = '''con prn aux nul
>
> Res? Resource names?... this is the primary reason I am opposed to
> no-underscores :p.
>
> -Sune
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>

Suggestion: The variables are only used within the checkwinfilename
function, so declare them within the function. The "windows" part of
the variable names is now implied. The variables could either be
inlined, or renamed: reservedfiles, reservedchars.

- Steve