Tentative fix for usehttp2=true
Augie Fackler
durin42 at gmail.com
Wed May 11 07:17:59 CDT 2011
On May 11, 2011, at 7:16 AM, Peter Arrenbrecht wrote:
> On Wed, May 11, 2011 at 2:13 PM, Augie Fackler <durin42 at gmail.com> wrote:
>> Wow, I'm dumb. I'll get a test and fix (probably what you posted) into the upstream library and then get it imported back into hg.
>
> Please also look into the read error I mentioned on IRC:
> http://paste.pocoo.org/show/386790/
> -parren
Was this repeatable consistently?
>
>>
>> On May 11, 2011, at 7:11 AM, Peter Arrenbrecht wrote:
>>
>>> Currently keepalive seems to be broken with usehttp2=true.
>>>
>>> diff --git a/mercurial/httpclient/__init__.py b/mercurial/httpclient/__init__.py
>>> --- a/mercurial/httpclient/__init__.py
>>> +++ b/mercurial/httpclient/__init__.py
>>> @@ -629,7 +629,7 @@
>>> r = self._current_response
>>> while r.headers is None:
>>> r._select()
>>> - if r.complete() or r.will_close:
>>> + if r.will_close:
>>> self.sock = None
>>> self._current_response = None
>>> else:
>>>
>>>
>>> -parren
>>
>>
More information about the Mercurial-devel
mailing list