[PATCH 2 of 2] httpclient: import revision fc731618702a of py-nonblocking-http

Matt Mackall mpm at selenic.com
Wed May 18 11:22:07 CDT 2011


On Wed, 2011-05-18 at 11:24 +0200, Martin Geisler wrote:
> Matt Mackall <mpm at selenic.com> writes:
> 
> > On Tue, 2011-05-17 at 13:36 -0500, Augie Fackler wrote:
> >> # HG changeset patch
> >> # User Augie Fackler <durin42 at gmail.com>
> >> # Date 1305646083 18000
> >> # Node ID 886fed778423d4dfc0f95fd7684a0c144cd934a5
> >> # Parent  8689945a9491d807e3a7154c544166a82423efa3
> >> httpclient: import revision fc731618702a of py-nonblocking-http
> >
> > These are queued, thanks.
> 
> I think we should think about making the httpclient a subrepo.
> 
> I agree that we should not add unnecessary pain for ourselves, but we
> now have a genuine third-party library that we depend on. It would be
> good for us to practise the subrepo workflow where, bugfixes would flow
> into our repo as patches that update the .hgsubstate file.
> 
> If we have done that, then we would have found out that even this simple
> workflow does not work! That is, when a patch updates .hgsubstate, we
> forget to check if any subrepos need updating.
> 
> This particular case might be easy to fix, but I'm want us to look at
> the bigger picture here: I feel that when we don't use a feature daily,
> then it will never be truely polished.

I'm pretty sure there are a few crew members using subrepos daily.

> Setup repo:
> 
>   $ hg init third-party
>   $ cd third-party
>   $ touch a
>   $ hg commit -A -m a
>   adding a
>   $ cd ..
> 
>   $ hg init repo
>   $ cd repo
>   $ hg clone $TESTTMP/third-party sub

..but I wouldn't structure it this way, as previously explained.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list