[PATCH 3 of 3 RFC v2] gitweb: display diffstat summary on the changeset page

Matt Mackall mpm at selenic.com
Thu May 19 15:01:58 CDT 2011


On Thu, 2011-05-19 at 21:19 +0800, Steven Brown wrote:
> # HG changeset patch
> # User Steven Brown <StevenGBrown at gmail.com>
> # Date 1305809843 -28800
> # Node ID babb3567fab7b7e15a54602faf8084461fb1ffb9
> # Parent  c6419d44010b495d2d430064414a86af1ae21f0b
> gitweb: display diffstat summary on the changeset page

So here's the thing about this patch: I despise Mercurial's gitweb style
almost as much as I despise git itself. It is both hideous and arcane
like its namesake and makes me cringe whenever I see it on a public
website with name 'Mercurial' attached to it. If I could delete it, I
would.

So I'm really reluctant to add new features to it that aren't also
present in the default style in some fashion, as that will encourage
even more people to use it.

So I think we should figure out whether it makes sense for this to be a
stock feature of hgweb styles.

Upsides:

- useful at-a-glance summary of relative amount of changes

Downsides:

- not well-defined for merges
- file lists can be arbitrarily long
- diffstat is monospaced ASCII - not really a great match for the web
- performance impact for large diffs

Possibilities:

- add a fold-out to paper to show the diffstat

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list