[PATCH 0 of 2 RFC] auditing paths on flag changes

Adrian Buehlmann adrian at cadifra.com
Sat May 21 17:32:09 CDT 2011


I'll most likely get a layering violation brown bag from Matt for this.

We probably need to have a design chat about which audit cache should
be used for what tree.

My understanding is, that the cache of the auditor of the repo's wopener is
conceptually tied to _the tree we're updating to_ (on 'hg update').

But we might have a problem already with the current design: What happens if
someone uses the same localrepo object for multiple operations (e.g. multiple
updates)?

merge.applyupdates currently uses a local transient auditor for files that are
unlinked. Which is good because thanks to this, these paths won't be added
to the auditor's cache of localrepo.wopener. But is this enough? Can't these
paths already be lingering in the auditor's cache of localrepo.wopener from earlier
file accesses?

Shouldn't we remove the paths of the files we are unlinking from the auditor's
cache?


More information about the Mercurial-devel mailing list