[PATCH V2] commands.remove: don't use workingctx.remove(list, unlink=True)

Matt Mackall mpm at selenic.com
Fri May 27 12:01:24 CDT 2011


On Fri, 2011-05-27 at 17:28 +0200, Adrian Buehlmann wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adrian at cadifra.com>
> # Date 1306504792 -7200
> # Node ID 96fb94b93798203fa0da1355c80d0381926ca3be
> # Parent  61f51f4a9a3b2fd76786fe0db88c4a10298975ee
> commands.remove: don't use workingctx.remove(list, unlink=True)

Queued, thanks.

> workingctx.remove(list, unlink=True) is unsuited here, because it does too
> much: it also unlinks added files. But the command 'hg remove' is specified
> to *never* unlink added files.

I think I'm either going to drop wctx.remove or rename it to unlink and
have it fall through to forget so there's no ambiguity. Still a ways to
go here until this stack of APIs is coherent.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list