[PATCH] hg-ssh: fix dispatch call to use dispatch.request()

[Martin Geisler]

Idan Kamara <idankk86 at gmail.com> writes:

> On Mon, May 30, 2011 at 10:53 AM, Martin Geisler <mg at lazybytes.net> wrote:
>
>> Idan Kamara <idankk86 at gmail.com> writes:
>>
>> > # HG changeset patch
>> > # User Idan Kamara <idankk86 at gmail.com>
>> > # Date 1306662911 -10800
>> > # Node ID 2a0f8e71f1c359b759caf9b2d1deea7905c746f3
>> > # Parent  d1a1578c5f7860b17f2f238b2c1e6adb555ffa4f
>> > hg-ssh: fix dispatch call to use dispatch.request()
>>
>> I don't know the details here, hence this mail :-)
>>
>> When I see such a commit message I ask questions like
>>
>> * Why is this needed? What is gained by this?
>
> Making hg-ssh work again.

Okay :-) Can you make a test case that use hg-ssh?

>> * You write 'fix', so something seems broken. This very likely worked
>> before, so why is this broken now?
>
> Because dispatch.dispatch now accepts a request object. I thought that
> was obvious from the summary.

Yeah, sort of -- when you say 'accepts' you mean 'requires', right?

>> * What changeset caused this to break?
>>
>
> I should have included that in the summary. It was obvious to me, but
> not to others apparently :).
>
> I'll resend.

Thank you!

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20110530/4a92754f/attachment.pgp>